-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 #13937
+2,466
−2,882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se into IslandRhythms/gh-13369
remove `count()`
allow null values for string enum
throw error after all saves are done
feat: change all symbols to use a consistent name
BREAKING CHANGE: make model.prototype.deleteOne() return query, not promise
upgrade eslint packages
…lt` option and `findOneAndRemove()`
…t()`, always convert sort args to objects Re: #13617
BREAKING CHANGE: stop using mquery for `updateX()`, `deleteX()`, `sort()`, always convert sort args to objects
i now have tested mongoose 8.0 with typegoose, where everything passes (both runtime and types), the steps i needed to take:
branch for reference (might be deleted in the future once 8.0 is out) |
fix(document): fix import file naming
…ndUpdate to findOneAndReplace Re: #13578
Let's goo boys, I need bson 6.x in my life 🙈 @vkarpov15 |
Remove `overwrite` option for `updateOne()`, `findOneAndUpdate()`, etc.
types(models): make all properties to Model constructor optional
IslandRhythms
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
8.0 is ready to go 👍 mostly relatively minor housekeeping changes. I think the biggest one will be allowing
null
for optional fields in TypeScript in #13901.Examples